Skip to content

Overview: Command line argument parsing, lexer #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Overview: Command line argument parsing, lexer #659

wants to merge 6 commits into from

Conversation

chrissimpkins
Copy link
Member

Work in progress on the Overview document.

Based on @mark-i-m branch in #633

@chrissimpkins chrissimpkins requested a review from mark-i-m April 3, 2020 05:47
@chrissimpkins chrissimpkins mentioned this pull request Apr 3, 2020
Merged
@chrissimpkins
Copy link
Member Author

chrissimpkins commented Apr 3, 2020 •
edited
Loading

@matklad @petrochenkov Mind having a look at the details on the lexers added here for our rustc-dev-guide Overview chapter? Do you have any suggestions about how we can expand upon/clarify the high-level details of the two stages of the lexical analysis?

LeSeulArtichaut
LeSeulArtichaut reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first review of c405ac3

chrissimpkins and others added 2 commits April 3, 2020 09:54
@chrissimpkins @LeSeulArtichaut
Update src/overview.md
f589c9b 
Co-Authored-By: LeSeulArtichaut <[email protected]>
@chrissimpkins @LeSeulArtichaut
Update src/overview.md
d8466ba 
Co-Authored-By: LeSeulArtichaut <[email protected]>
@mark-i-m mark-i-m added the S-blocked Status: this PR is blocked waiting for something label Apr 3, 2020
@petrochenkov petrochenkov self-assigned this Apr 3, 2020
@mark-i-m
Copy link
Member

mark-i-m commented Apr 3, 2020

Hi everyone: in an effort to avoid merge conflicts, I'm proposing that we merge this into #633 and continue working there. Does anyone have objections to this?

cc @Centril @petrochenkov @matklad @rust-lang/wg-rustc-dev-guide

@petrochenkov petrochenkov removed their assignment Apr 3, 2020
@chrissimpkins chrissimpkins changed the title [WIP] Overview: Command line argument parsing, lexer, parser Overview: Command line argument parsing, lexer Apr 4, 2020
@mark-i-m
Copy link
Member

mark-i-m commented Apr 4, 2020

Merged in #633

Thanks all!

@mark-i-m mark-i-m closed this Apr 4, 2020
@chrissimpkins
Copy link
Member Author

Ty!

@mark-i-m
Copy link
Member

mark-i-m commented Apr 4, 2020

I've copied over the comments from this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshepang tshepang tshepang left review comments

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut left review comments

@petrochenkov petrochenkov petrochenkov approved these changes

@mark-i-m mark-i-m Awaiting requested review from mark-i-m

@matklad matklad Awaiting requested review from matklad

Assignees
No one assigned
Labels
S-blocked Status: this PR is blocked waiting for something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrissimpkins @mark-i-m @tshepang @petrochenkov @LeSeulArtichaut